Issue with field ordering for serializr
#13
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I specify the model schema for 2 classes where one extends the other, the order of fields during serialization of the subclass sometimes do not follow the order specified in in
createModelSchema. Look at the example I providedI have 2 classes
PersonandWorker extends Person. When usingcreateModelSchema, if I specify the model schema forPersonbefore I specify the model schema forWorker, when I try to serialize an instance ofWorker, the props in the model schema ofWorkerwhich overlap with the props in the model schema ofPersonwill always be arranged first, and the fields which specialized toWorkerwill be arranged last, in the example, I'm trying to serialize usingworkerModelSchema, which specifiescompanyfield to go beforename, but in the output, I don't see this.Now, if I use the (1), where I specify the model schema of
Workerbefore I doPerson, I would get what I expected, or if I do (3) where I avoid usingcreateModelSchema, I would get what I expected as well.I really think this is a bug due to the inconsistency we see here, I suppose this has to do with some intricate handling we do in
createModelSchema