feat(api server): add support for streaming logs from completed analysisruns#3678
Merged
krancour merged 11 commits intoakuity:mainfrom Mar 24, 2025
Merged
Conversation
krancour
added
kind/enhancement
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3678 +/- ##
==========================================
+ Coverage 21.81% 21.90% +0.09%
==========================================
Files 310 312 +2
Lines 64652 65210 +558
==========================================
+ Hits 14105 14287 +182
- Misses 49782 50154 +372
- Partials 765 769 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hiddeco
reviewed
Mar 20, 2025
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
krancour
force-pushed
the
krancour/verification-logs-endpoint
branch
from
1a34a9e to
7cd2fb6
Compare
hiddeco
reviewed
Mar 20, 2025
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com> Co-authored-by: Hidde Beydals <hiddeco@users.noreply.github.com>
hiddeco
approved these changes
Mar 20, 2025
Member
Author
krancour
added
the
do not merge yet
Contributor
|
I am testing this against UI |
gdsoumya
reviewed
Mar 23, 2025
| {{- range $key, $value := .Values.api.rollouts.logs.httpHeaders }} | ||
| {{- $headers = append $headers (printf "%s=%s" $key $value) }} | ||
| {{- end }} | ||
| ANALYSIS_RUN_LOG_HTTP_HEADERS: {{ quote (join "," $headers) }} |
Contributor
There was a problem hiding this comment.
just ensuring the expected value here is header1=val1,header2=val2,... right?
Member
Author
There was a problem hiding this comment.
It's also tolerant of whitespace around commas if there should happen to be any.
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
krancour
removed
the
do not merge yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIPBack end components of #3641
Still needs corresponding functionality added to CLI.DoneUI components to be added in a follow-up PR. (#3674)
cc @jessesuen @hiddeco @Marvin9 @gdsoumya