🧪 Add tests for CSimulator simulator property#199
Conversation
Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…f active file handles and temporary directories Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
…fic FileNotFoundError Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
…fic FileNotFoundError Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
bd7d4c0 to
690c829
Compare
🎯 What: The testing gap in
bionetgen/simulator/csimulator.py:224for theCSimulator.simulatorproperty (getter and setter) has been addressed. The logic inside the setter validates initial species counts and parses/filters numeric parameters before initializingCSimWrapper.📊 Coverage: The new tests cover:
simulatorsetter: Mocking valid, ignored (starting with_), and non-float evaluating parameters to test the filtering, and mocking initial species count, validatingCSimWrapperis instantiated with the correctnum_paramsandnum_spec_init._simulator.BNGCompileErrorwhenCSimWrapperraises an exception during initialization.✨ Result: Test coverage for
bionetgen/simulator/csimulator.pyis improved, increasing confidence in theCSimulatorwrapper logic.PR created automatically by Jules for task 6771044870234571453 started by @akutuva21