Skip to content

🧪 Add tests for CSimulator simulator property#199

Merged
akutuva21 merged 8 commits into
mainfrom
jules-6771044870234571453-671e633b
May 28, 2026
Merged

🧪 Add tests for CSimulator simulator property#199
akutuva21 merged 8 commits into
mainfrom
jules-6771044870234571453-671e633b

Conversation

@akutuva21
Copy link
Copy Markdown
Owner

🎯 What: The testing gap in bionetgen/simulator/csimulator.py:224 for the CSimulator.simulator property (getter and setter) has been addressed. The logic inside the setter validates initial species counts and parses/filters numeric parameters before initializing CSimWrapper.

📊 Coverage: The new tests cover:

  1. The happy path for simulator setter: Mocking valid, ignored (starting with _), and non-float evaluating parameters to test the filtering, and mocking initial species count, validating CSimWrapper is instantiated with the correct num_params and num_spec_init.
  2. The getter property returning the mocked _simulator.
  3. Error handling: Explicitly raising BNGCompileError when CSimWrapper raises an exception during initialization.

Result: Test coverage for bionetgen/simulator/csimulator.py is improved, increasing confidence in the CSimulator wrapper logic.


PR created automatically by Jules for task 6771044870234571453 started by @akutuva21

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules Bot and others added 3 commits May 16, 2026 19:46
…f active file handles and temporary directories

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
…fic FileNotFoundError

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
…fic FileNotFoundError

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@akutuva21 akutuva21 marked this pull request as ready for review May 28, 2026 16:52
@akutuva21 akutuva21 force-pushed the jules-6771044870234571453-671e633b branch from bd7d4c0 to 690c829 Compare May 28, 2026 18:56
@akutuva21 akutuva21 merged commit c96ffa9 into main May 28, 2026
1 check failed
@akutuva21 akutuva21 deleted the jules-6771044870234571453-671e633b branch May 28, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant