Fix whatsmars misplaced corrections#2
Open
knewbury01 wants to merge 1 commit intoakwick:thesis-2018-anam-dodhyfrom
knewbury01:kristen-whatsmars-pr
Open
Fix whatsmars misplaced corrections#2knewbury01 wants to merge 1 commit intoakwick:thesis-2018-anam-dodhyfrom knewbury01:kristen-whatsmars-pr
knewbury01 wants to merge 1 commit intoakwick:thesis-2018-anam-dodhyfrom
knewbury01:kristen-whatsmars-pr
Conversation
Previously correct-usage file for whatsmars misuse 10 & 11 contained a correct pattern for insecure parameter to cipher object type of misuse, however the 10 & 11 yml file lists misuse as the following: First parameter while initializing SecretKeySpec was not properly randomized. Replaced the correct-usages files with the same solution as for whatsmars misuse 6, because these are the same misuse issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously correct-usage file for
whatsmars misuse 10 & 11 contained
a correct pattern for insecure parameter
to cipher object type of misuse, however
the 10 & 11 yml file lists misuse as the following:
First parameter while initializing SecretKeySpec
was not properly randomized.
Replaced the correct-usages files
with the same solution as for whatsmars
misuse 6, because these are the same misuse issue.
This looks to me to be a simple file misplacement issue, the fix is also simple ,
but let me know if you would like it addressed in any other way :)