Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019cb6e5-b085-71df-b3d6-48a08c1dbc33 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019cb6e5-b085-71df-b3d6-48a08c1dbc33 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019cb6e5-b085-71df-b3d6-48a08c1dbc33 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019cb6f9-8a05-71af-a673-b14781c702a2 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors across the CLI, TUI, service layer, and documentation to enhance authentication handling, agent card retrieval, and developer experience. The most significant changes are the addition of robust fallback logic for agent card discovery, improved credential management throughout the CLI and TUI, and expanded test coverage for authentication flows.
Agent card retrieval improvements:
A2AService.get_cardmethod now tries the standard well-known path (agent-card.json) first, and falls back to the legacy path (agent.json) if needed, improving compatibility with older agents. This fallback logic is also used in validation routines. [1] [2]Authentication and credential management:
-a/--authenticatedis used, and the TUI can be preconfigured with a bearer token via a new option. Credentials are properly cleared when not needed. [1] [2] [3] [4] [5] [6] [7] [8] [9]Service layer enhancements:
A2AServiceclass adds aclear_credentialsmethod to remove authentication headers and reset the client cache, ensuring correct behavior when switching between authenticated and unauthenticated requests.Documentation and developer experience:
AGENTS.mddocumentation is updated to clarify environment management withuvand to specify conventional commit message requirements. [1] [2]pyproject.tomlfora2a-sdkandgoogle-adk.Expanded test coverage:
Let me know if you want to walk through any of these changes in more detail!