Add support for nested transactions. #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge the TransactionExecutor interface into QueryExecutor, and implement the neccessary support so that any QueryExecutor can start a new transaction. If the QueryExecutor is already a transaction, it will create a new savepoint in the database.
Owner
|
Merged. Great stuff, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #36, it seems useful to support nested transactions.
These changes move the functionality of the TransactionExecutor interface (begin()) into the QueryExecutor interface, allowing any QueryExecutor (currently a Db/Connection or a Transaction) to start a new transaction.
This makes it easier to write generalized code, a QueryExecutor can be passed in, and a (sub-)transaction can be run using it regardless of what happens before/after the function is called.