Model branch by alamriku · Pull Request #37 · alamriku/LMS

alamriku · 2020-11-07T06:41:46Z

No description provided.

…m intermediary pivot table

me-shaon · 2020-11-08T14:43:52Z

+
+class Author extends Model
+{
+    use HasFactory;


Add SoftDeletes trait.

Fix in other places too.

me-shaon · 2020-11-08T14:45:03Z

+
+    public function books()
+    {
+        return $this->belongsToMany('App\Models\Book')->using('App\Models\AuthorBook');


Use like this:

return $this->belongsToMany(Book::class)->using(AuthorBook::class);

It'll be easier for the IDE to reference.

Fix in other places too.

me-shaon · 2020-11-08T14:45:52Z

+class AuthorBook extends Pivot
+{
+    public $incrementing = true;
+    use HasFactory;


Trait statement should be the first line inside the Class.

me-shaon · 2020-11-08T14:46:16Z

+{
+    use HasFactory;
+
+    public function authors(){


{ should be placed in the next line.

me-shaon · 2020-11-08T14:46:44Z

+    public function bookOfCopies(){
+        return $this->hasMany('App\Models\BookCopy');
+    }
+


Remove unnecessary empty lines.

me-shaon · 2020-11-08T14:58:00Z

+{
+    use HasFactory;
+
+    public function userHaveCopy(){


The naming doesn't seem right. Please check. Think about the naming from the usage. For example, in your case it would be:

$bookUser = new BookUser(); $bookUser->userHaveCopy;

$bookUser->userHaveCopy it doesn't sound good.

Same is for the below method bookOfUser.

me-shaon · 2020-11-09T12:49:18Z

+{
+    use HasFactory;
+
+    public function GenreBooks(){


Fix the naming and put the { on the next line.

Fix in other places too.

me-shaon · 2020-11-09T12:52:16Z

            $table->string('name');
-            $table->string('image');
+            $table->string('image')->nullable();
            $table->text('description');


should be nullable.

me-shaon · 2020-11-09T12:52:26Z

            $table->string('name');
-            $table->string('logo');
+            $table->string('logo')->nullable();
            $table->text('description');


should be nullable.

me-shaon · 2020-11-09T12:54:12Z

+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class AddDropForeignOnAuthorBookTable extends Migration


Why creating separate migration for 'foreign keys'? It would be hard to maintain.

could't write the drop code on down method. I have take this step.

Done. foreign key drop added on there specific table migration file.

…odel

alamriku added 28 commits November 6, 2020 22:19

update: default value false added to is_banned on users

017527e

image nullable

5078228

logo nullable on publicaitons

39e7350

slug is unique on genres

add50e9

book slug unique done

f8c5cf6

books image nullable

e5c2bbb

default zero on books total_copies

db5ce90

available copies default zero

a6b4cfc

uuid unique done

553db2f

default true on isavaiable on book_copies

049890d

loan_requests status_change_by foreign key relation added

26c4d93

status_change_by relationship done on return_request

17ffe80

drop foreign key added on author_book table

76300b1

add dropForeign key on book_copies:

7f73dff

drop_foreing key on book_genre done

fd8638d

dropForeign key on loan_request

06169b9

drop_foreign_on_return_requests

6db7d38

drop foreign key added on book_user table

1f0466a

model created

b584f7c

bookUser model created for book_user resource table

b11520d

relation ship between author and book by pivot table done using custo…

0e6a8d0

…m intermediary pivot table

relation model method added on book and publication model

17269f0

relationship method done on book and genre

45624d3

relation method added on book and bookCopy

fe75ea8

relation between book_user and book_copies have done

a91c626

relation method added on bookUser and User model

118d850

relation for copy added by on user and book copy done

a3dc0ed

loan and return relation method added on loan ,request, user model

fe9b6d6

me-shaon requested changes Nov 9, 2020

View reviewed changes

foreign key relatin done on the table migration file

a0f0de8

alamriku added 18 commits November 10, 2020 21:21

default value User as role on user table used as constant from user m…

4ad6192

…odel

const condition added on book_copies migration file

e19e18d

pending const added on loanRequest migration file

d2869c8

Pending const added on return request migration file

4090aaf

{ space fixed

beb176f

{ space on user is fixed

6a13fdd

trait on top in authorbook

3035021

soft delete trait added on all model

491c739

model relation done so that ide can reference it

d330d2e

method naming updated on user model

8f9f8d2

method name updated on returnRequest

d1b8b5a

update:method name on publication model

7eb94bb

update:method name change on loandRequest model

ce2dc7e

Update:method name on Book,BookCOpy,Bookuser,Genre model

2b8af7b

relation as status change by between user and request done

efe68b5

relation between loanRequest ,ReturnRequest,BookUser done

f27a857

boiler plate template done

79d17d2

remove the template part from modelBranch

0aaa6d4

Conversation

alamriku commented Nov 7, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants