forked from pfn/keepasshttp
-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Description
The existing protocol use AES-256-CBC with PKCS7 padding but no message authentication, making it vulnerable to CBC padding oracle attacks.
Changes:
- Add HMAC-SHA256 computation over (IV + ciphertext) for Encrypt-then-MAC
- Responses always include the Hmac field for clients that support it
- Requests with Hmac field are verified before decryption (fail-fast)
- Requests without Hmac field still work (backward compatible)
- Add constant-time comparison to prevent timing side-channel attacks
- Add Hmac field to
BaseRequestandBaseResponsemodels
Reactions are currently unavailable