Add functional tests #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iain-S
force-pushed
the
functional-tests
branch
3 times, most recently
from
84ff995 to
bc3614e
Compare
Iain-S
force-pushed
the
functional-tests
branch
from
bc3614e to
2cd4d8b
Compare
Iain-S
force-pushed
the
functional-tests
branch
from
2cd4d8b to
9812719
Compare
Iain-S
force-pushed
the
functional-tests
branch
from
9812719 to
a8e733a
Compare
Collaborator
Author
|
@myyong The functional tests run fine for me and on the GH Action. Could you check that they work for you and let me know if I should add some more explanation to the Testing section of the README? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add an end-to-end test to check that running each CLI command in turn gives no errors.
Detail
Adds a functional test in
test_functional.pythat runs each of the CLI commands in the proper order. That unit test expects a postgres db to be up and running and to have a database namedsrc. In the GitHub action, we set up such a database. Since the unit test is destructive (it overwrites any src and dst databases it connects to) we require an env var to be set to run the test.Misc
Closes #10