Skip to content

Conversation

@Iain-S
Copy link
Collaborator

@Iain-S Iain-S commented Feb 24, 2023

Note that the docs dependencies are now installed as a package "extra" (poetry install --all-extras or pip install sqysynthgen[docs]) rather than via a separate requirements.txt. This means that

  1. users installing with pip install sqlsynthgen won't get the docs deps, thanks to optional = true
  2. developers installing with --all-extras will have the normal and docs dependencies all within one virtual env
  3. documentation deps are more loosely defined than when using requirements because we use ^1.2.3 and not ==1.2.3

@Iain-S Iain-S added the WIP label Feb 24, 2023
@Iain-S Iain-S changed the title Fail docs build if sphinx emits any warnings Edits to the docs Feb 24, 2023
@Iain-S Iain-S force-pushed the iain-s/docs branch 6 times, most recently from 0ccbf7b to a5a7503 Compare February 27, 2023 14:41
@Iain-S Iain-S removed the WIP label Feb 27, 2023
@Iain-S Iain-S requested a review from mhauru February 27, 2023 14:56
@Iain-S Iain-S merged commit 88e8173 into main Feb 27, 2023
@Iain-S Iain-S deleted the iain-s/docs branch February 27, 2023 16:20
tim-band pushed a commit to tim-band/sqlsynthgen that referenced this pull request Jun 11, 2025
tim-band pushed a commit to tim-band/sqlsynthgen that referenced this pull request Jun 11, 2025
tim-band added a commit to tim-band/sqlsynthgen that referenced this pull request Jun 18, 2025
* Tests all pass individually now. Many fixes:
* create-vocab actually runs
* create-data reports correct count of story rows
* -f can be used as well as --force
* the logger is called "datafaker" not "utils"
* row generators can fully exhaust unique constraints
* row/story generator modules can just be files (this may just have been broken for tests)
* turning on max constraint retries doesn't break create-data
* unique constraint failure does not blow up datafaker

* More test robustness

* alan-turing-institute#44 create-generators figures out if it needs a stats file

* bump version to 0.2.1

---------

Co-authored-by: Tim Band <t.b@ucl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants