Write the output of make-[tables|generators] to a file #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iain-S
force-pushed
the
make-commands-write-to-file
branch
from
c4144fd to
011b855
Compare
Iain-S
force-pushed
the
make-commands-write-to-file
branch
from
db914d1 to
eb95448
Compare
And correct some docstrings.
And correct some docstrings.
Iain-S
force-pushed
the
make-commands-write-to-file
branch
from
f0f828b to
b1ce6e8
Compare
Change import_module so that it imports files from the cwd Error if any file we try to write already exists
Iain-S
force-pushed
the
make-commands-write-to-file
branch
from
b1ce6e8 to
f15f673
Compare
mhauru
approved these changes
Mar 1, 2023
Collaborator
mhauru
left a comment
mhauru
left a comment
There was a problem hiding this comment.
One minor request and one general comment, good otherwise
| run_psql("dst.dump") | ||
|
|
||
| def test_workflow(self) -> None: | ||
| os.chdir("tests/workspace") |
Collaborator
There was a problem hiding this comment.
I wanted to use a tmp_path pytest fixture for this, to use a temporary folder that shouldn't conflict with anything existing, but pytest fixtures don't play nicely with unittest.TestCase subclasses. (https://docs.pytest.org/en/6.2.x/unittest.html)
Collaborator
Author
There was a problem hiding this comment.
Yeah, I think there must be a nicer way to do this than chdir() in the test functions / in the setUp. I could imagine the current way might cause some interdependence between tests if one fails in the setup before the first chdir().
Iain-S
force-pushed
the
make-commands-write-to-file
branch
from
18e6b65 to
d648f99
Compare
tim-band
added a commit
to tim-band/sqlsynthgen
that referenced
this pull request
Jun 19, 2025
* sampled and suppressed choice generators * Fixed problems found trying this out for real. --------- Co-authored-by: Tim Band <t.b@ucl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently write the output of the
make-commands to stdout but this doesn't work so well now that we also write other files (e.g. vocab.csvfiles during make-generators and, potentially,stats.yaml).This is a big single commit where we:
--ssg-file=myfilename.py, etc.sys.exit(1)if an ORM, SSG or vocab file we are trying to write already exists (up for debate)main.pyormake.py, which lead to some funny behaviour. We now require the file to be in the current working dir, which necessitated several test changes.tests/tmptotests/workspaceand run our functional tests there.with patch("") as mock_somethingcontext managers for@patch("")test function decorators for better readability (and quicker to create/delete patch calls this way).For the reviewer: