Addressed most of my comments on PR 291 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize mrcStepNames to [].
Removed "if (state && state.stepNames) {" from loadExtraState.
Add braces to if statements.
Changed python code that checks whether _initialize_steps has been set.
Added createStepsBlocks function to create the steps block for the toolbox.
In methods_category.ts:
Modified MethodsCategory.methodsFlyout to call createStepsBlocks to create the mrc_steps block for the toolbox.
alan412
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize mrcStepNames to [].
Removed "if (state && state.stepNames) {" from loadExtraState.
Add braces to if statements.
Changed python code that checks whether initialize_steps has been set.
Added createStepsBlocks function to create the steps block for the toolbox.
Added constants for INPUT_CONDITION_PREFIX and INPUT_STEP_PREFIX.
Moved code to add shadow True blocks from updateShape to compose.