Make it work on systemcore #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compare port_type with PortType.BASE_COMPOUND, use .value to get the numeric value.
Added type hints for function returns.
Modified get_type to just return self.type.
In component.py:
Changed port.get_type to port.get_type().
In mrc_port.ts, in pythonFromBlock:
Changed _generator to generator.
Added generator.addImport('port');
Changed Port to port.Port in generated python code.
Changed PortType to port.PortType in generated python code.
Changed MOTOR_PORT to EXPANSION_HUB_MOTOR_PORT.
Changed SERVO_PORT to EXPANSION_HUB_SERVO_PORT.
Updated external_samples_data.json.
alan412
approved these changes
Aug 31, 2025
Owner
alan412
left a comment
alan412
left a comment
There was a problem hiding this comment.
Thanks for testing this and getting it working!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it work on systemcore.
In port.py:
When compare port_type with PortType.BASE_COMPOUND, use .value to get the numeric value. Added type hints for function returns.
Modified get_type to just return self.type.
In component.py:
Changed port.get_type to port.get_type().
In mrc_port.ts, in pythonFromBlock:
Changed _generator to generator.
Added generator.addImport('port');
Changed Port to port.Port in generated python code. Changed PortType to port.PortType in generated python code. Changed MOTOR_PORT to EXPANSION_HUB_MOTOR_PORT.
Changed SERVO_PORT to EXPANSION_HUB_SERVO_PORT.
Updated external_samples_data.json.