Deprecate normalisedMark in evidenceFeed & add gradientMark in replacement for 25.0 [SA-20057] #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brahmah
reviewed
May 27, 2025
| gradientMark: | ||
| type: string | ||
| nullable: true | ||
| description: The gradient colour equivalent of the mark. "none" if gradient marks are disabled. |
Contributor
There was a problem hiding this comment.
It could be helpful to include that this is usually a string value from 0-10?
I'd also suggest that the difference between null and "none" is ambiguous here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new input/display mark types in 25.0:
normalisedMarkis now deprecated in the evidenceFeed API to prevent student's from viewing more granularity of grades than the display mark type would otherwise allow them to viewgradientMarkhas been added to account for the one location we internally used the other fieldThe normalised mark is still available under
GET /api/assessment/{id}gradientMark can be:
string: If the grade gradient config is enabled and a mark exists (at the moment, this is from 0 to 10)null: If there's no corresponding colour visualisation, including when it's disabled via admin.