Skip to content

fix ceph object dr#333

Merged
Muyan0828 merged 2 commits intomasterfrom
ceph-object-dr
Nov 14, 2025
Merged

fix ceph object dr#333
Muyan0828 merged 2 commits intomasterfrom
ceph-object-dr

Conversation

@Muyan0828
Copy link
Copy Markdown
Contributor

@Muyan0828 Muyan0828 commented Nov 14, 2025

Summary by CodeRabbit

  • Documentation

    • Adjusted title capitalization in the Ceph object store user creation guide and updated accompanying explanatory text.
  • Configuration Changes

    • Changed default per-user bucket quota from unlimited to 100; size and object quotas remain unrestricted by default.
  • Disaster Recovery

    • Added new block pool configurations to both primary and secondary setups to improve failover and disaster recovery resilience.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 14, 2025

Walkthrough

Documentation edits: adjusted title capitalization and default quota for CephObjectStoreUser; added two CephBlockPool YAML examples (builtin-rgw-root) to Primary and Secondary sections of the disaster recovery how-to.

Changes

Cohort / File(s) Summary
CephObjectStoreUser docs
docs/en/storage/storagesystem_ceph/how_to/create_object_user.mdx
Normalized title capitalization; changed default quotas.maxBuckets from -1 (unlimited) to 100 in example/spec and updated accompanying explanatory text.
Disaster Recovery (CephBlockPool examples)
docs/en/storage/storagesystem_ceph/how_to/disaster_recovery/dr_object.mdx
Appended two CephBlockPool resource examples named builtin-rgw-root (Primary and Secondary). Each defines pool .rgw.root, application: rgw, failureDomain: host, replicated.size: 3, pg_num: "8", and label cpaas.io/builtin: "true".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Small, focused documentation edits and example YAML additions.
  • Checkpoints: verify quota semantic change in docs matches implementation expectations; ensure appended CephBlockPool examples use correct naming/labels and placement in the DR doc.

Suggested reviewers

  • fanzy618

Poem

🐰 I hopped through lines of text today,

Capital letters found their way.
Quotas set and pools in tune,
Docs now hum a safer tune.
🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix ceph object dr' is vague and lacks specificity. It uses abbreviated terminology ('dr' for disaster recovery) and doesn't clearly communicate what specific issue is being fixed or what the main changes accomplish. Consider using a more descriptive title such as 'Add default quota limits and fix Ceph disaster recovery configuration' or 'Configure default maxBuckets quota and add RGW pool for Ceph DR' to better convey the scope of changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ceph-object-dr

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d09676b and c3d7cab.

📒 Files selected for processing (1)
  • docs/en/storage/storagesystem_ceph/how_to/create_object_user.mdx (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/en/storage/storagesystem_ceph/how_to/create_object_user.mdx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
docs/en/storage/storagesystem_ceph/how_to/disaster_recovery/dr_object.mdx (1)

279-296: Consistent pool definitions across Primary and Secondary, but documentation lacks explanation.

The CephBlockPool addition to the Secondary zone mirrors the Primary zone definition correctly, which is good for multi-site DR consistency. However, the PR lacks explanation for why this pool is necessary for the DR setup. Consider adding a brief comment or documentation note explaining that the .rgw.root pool stores RGW metadata required for multi-site replication.

Recommended: Add explanatory comment to documentation.

Consider updating the section header or adding a brief explanation before the YAML block in both Primary and Secondary sections:

+        This step includes the necessary `.rgw.root` pool (builtin-rgw-root) which stores RGW metadata required for multi-site replication and disaster recovery.
+
         ```yaml
         cat << EOF | kubectl apply -f -

Additionally, verify line 296 for unintended trailing whitespace:

#!/bin/bash
# Check for trailing content on line 296 in dr_object.mdx
sed -n '296p' docs/en/storage/storagesystem_ceph/how_to/disaster_recovery/dr_object.mdx | od -c | head -5
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b04ede6 and d09676b.

📒 Files selected for processing (2)
  • docs/en/storage/storagesystem_ceph/how_to/create_object_user.mdx (2 hunks)
  • docs/en/storage/storagesystem_ceph/how_to/disaster_recovery/dr_object.mdx (2 hunks)
🔇 Additional comments (2)
docs/en/storage/storagesystem_ceph/how_to/create_object_user.mdx (1)

5-5: Title capitalization normalized.

Style improvement for consistency with documentation standards.

docs/en/storage/storagesystem_ceph/how_to/disaster_recovery/dr_object.mdx (1)

92-109: CephBlockPool definition is correctly formatted; no trailing whitespace detected.

Verification confirms line 108 has no trailing whitespace. The CephBlockPool resource for builtin-rgw-root is well-structured and appropriate for the disaster recovery multi-site setup.

Comment thread docs/en/storage/storagesystem_ceph/how_to/create_object_user.mdx
@Muyan0828 Muyan0828 merged commit 0096837 into master Nov 14, 2025
1 of 2 checks passed
@Muyan0828 Muyan0828 deleted the ceph-object-dr branch November 14, 2025 07:01
@coderabbitai coderabbitai Bot mentioned this pull request Dec 4, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant