Skip to content

remove global support calico#363

Merged
chinameok merged 1 commit intomasterfrom
AIT-62838
Dec 1, 2025
Merged

remove global support calico#363
chinameok merged 1 commit intomasterfrom
AIT-62838

Conversation

@chinameok
Copy link
Copy Markdown
Contributor

@chinameok chinameok commented Dec 1, 2025

Summary by CodeRabbit

  • Documentation
    • Updated IP protocol family configuration guidance, clarifying IPv6 requirements for single-stack cluster setup
    • Simplified installer startup flow documentation
    • Generalized network condition prerequisites
    • Refined network policy requirements

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 1, 2025

Walkthrough

This PR updates installation documentation to reflect changes in network configuration handling. It removes references to network plugin selection from the installer startup flow, updates IP Family guidance for IPv6 deployments, simplifies cluster-type conditionals, and removes Calico-specific IP-in-IP protocol requirements from prerequisites.

Changes

Cohort / File(s) Change Summary
Network Plugin Selection Removal
docs/en/install/overview.mdx
Removed instruction to select network plugin (Kube-OVN or Calico) during installer startup; Execution Stage now only references IP protocol mode and VIP configuration selection.
IP Family Configuration Update
docs/en/install/installing.mdx
Replaced Network Mode/IP Family subsection; removed --network-mode calico example and added --ip-family ipv6 example with guidance that Single-stack IPv6 for global clusters requires explicit --ip-family ipv6 parameter.
Conditional Wording Refinements
docs/en/install/prepare/node_preprocessing.mdx
Changed port occupancy check condition from "If the global cluster uses Kube-OVN or Calico" to "If the cluster uses Kube-OVN or Calico" (removed "global" qualifier).
Calico-Specific Requirements Removal
docs/en/install/prepare/prerequisites.mdx
Removed Calico CNI-specific note about IP-in-IP protocol enablement from Network Policy row; simplified reference to port forwarding rules.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Suggested focus areas:
    • Verify that removing network plugin selection from overview.mdx aligns with actual installer behavior changes
    • Confirm IPv6 deployment guidance accuracy in installing.mdx
    • Check for other documentation files that may reference the removed network plugin selection flow

Possibly related PRs

  • acp-docs#360: Modifies network prerequisites content in prerequisites.mdx, aligning with the removal of Calico-specific requirements in this PR
  • acp-docs#248: Updates both node_preprocessing.mdx and prerequisites.mdx installation documentation files
  • acp-docs#239: Modifies prerequisites.mdx for resource planning updates

Suggested reviewers

  • fanzy618
  • timonwong

Poem

🐰 Network paths now clearer, IPv6 shines bright,
No plugin selections cluttering the installer's flight,
Calico notes trimmed, conditions refined,
Simpler docs for clusters of every kind! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'remove global support calico' accurately describes the main change: removal of Calico CNI-specific requirements and global cluster instructions from installation documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch AIT-62838

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1788b7 and 3b6fbb9.

📒 Files selected for processing (4)
  • docs/en/install/installing.mdx (1 hunks)
  • docs/en/install/overview.mdx (1 hunks)
  • docs/en/install/prepare/node_preprocessing.mdx (1 hunks)
  • docs/en/install/prepare/prerequisites.mdx (1 hunks)
🔇 Additional comments (4)
docs/en/install/overview.mdx (1)

30-30: Streamlined startup flow documentation aligns with PR objectives.

The removal of network plugin selection from the installer startup description appropriately reflects the simplified installation flow. The updated text clearly focuses on the two key startup decisions: IP protocol mode and VIP configuration.

Please verify that the actual installer behavior matches this updated documentation—specifically, confirm that users are no longer prompted to select between Kube-OVN and Calico during startup, and that network plugin selection has been moved or removed from the installer entirely.

docs/en/install/prepare/node_preprocessing.mdx (1)

122-122: Verify the scope of generalized cluster condition.

The removal of the "global" qualifier generalizes this check from "If the global cluster uses Kube-OVN or Calico" to "If the cluster uses Kube-OVN or Calico." Please confirm whether this scope expansion is intentional—does this port occupancy requirement now apply to all clusters (including workload clusters), or should the text remain specific to the global cluster?

docs/en/install/prepare/prerequisites.mdx (1)

169-169: Network Policy requirement simplified appropriately.

The removal of the Calico CNI-specific IP-in-IP protocol requirement cleanly aligns with the PR objective to remove Calico-specific configuration from the installation prerequisites. The simplified text now focuses on the LoadBalancer Forwarding Rules, which is the essential prerequisite.

docs/en/install/installing.mdx (1)

44-50: IP Family guidance is clear and well-positioned.

The new IP Family subsection is well-structured, concise, and provides actionable guidance for users deploying Single-stack IPv6 environments. The example is practical, and the documentation of default behavior (Single-stack IPv4 and Dual-stack IPv4/IPv6 by default) is helpful for users who do not explicitly specify the parameter.

Verify that no other sections in the installing.mdx file (or related documentation) still reference --network-mode or require network plugin selection, to ensure this change is complete and consistent throughout the documentation.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chinameok chinameok merged commit ce5fedb into master Dec 1, 2025
2 of 3 checks passed
@chinameok chinameok deleted the AIT-62838 branch December 1, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant