Conversation
🦋 Changeset detectedLatest commit: ea22e7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe update introduces a changeset file documenting a patch release for a callouts style fix, modifies a SCSS selector to target a more specific class within callouts, and removes an unused plugin from the remark configuration. No changes were made to exported or public entities. Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the callout list styling and removes an unused lint rule from the Remark configuration.
- Change nested ordered list selector to use a dedicated
.rp-list-decimalclass - Remove
listItemSizeplugin import and reference inremarkrc.ts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| styles/global.scss | Replace > ol selector with .rp-list-decimal for callout lists |
| src/remarkrc.ts | Remove unused listItemSize lint rule from imports and plugin list |
Comments suppressed due to low confidence (2)
styles/global.scss:72
- [nitpick] Consider adding a comment or updating documentation to explain the purpose and usage of the
.rp-list-decimalclass, so future maintainers know when to apply it in markup.
> .rp-list-decimal {
src/remarkrc.ts:15
- [nitpick] Since
listItemSizewas removed, consider updating or adding tests to cover lint behavior without this rule to prevent regressions in list formatting checks.
noDeepHeading,
Signed-off-by: JounQin <admin@1stg.me>
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.changeset/dry-fireants-mate.md (1)
1-6: Trailing-newline nitpickFile is well-formed; adding a final newline keeps POSIX-style editors & Git happy.
fix: callouts style +styles/global.scss (1)
87-93: Uncommon selector grouping may hinder readability
> { ul, ol { … } }is valid SCSS, yet many devs aren’t familiar with this pattern. A flattened form costs two lines but is clearer:- > { - ul, - ol { - margin-left: 1.25rem; - } - } + > ul, + > ol { + margin-left: 1.25rem; + }Purely a readability suggestion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/dry-fireants-mate.md(1 hunks)src/remarkrc.ts(0 hunks)styles/global.scss(1 hunks)
💤 Files with no reviewable changes (1)
- src/remarkrc.ts
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: JounQin
PR: alauda/doom#30
File: src/runtime/components/K8sCrd.tsx:5-5
Timestamp: 2025-05-26T09:09:21.339Z
Learning: JounQin has mentioned multiple times that the alauda/doom project uses yarn v4, and there are no ESLint import resolution errors for @rspress/core subpath imports.
Learnt from: JounQin
PR: alauda/doom#34
File: src/cli/load-config.ts:290-0
Timestamp: 2025-05-29T10:23:34.965Z
Learning: In the @alauda/doom project, JounQin prefers concise error handling over verbose validation. While they prefer throwing on invalid configuration rather than graceful fallbacks, they don't want overly detailed validation with multiple explicit checks and error messages.
.changeset/dry-fireants-mate.md (6)
Learnt from: JounQin
PR: alauda/doom#75
File: src/cli/load-config.ts:4-7
Timestamp: 2025-06-09T03:10:41.010Z
Learning: The alauda/doom project uses yarn v4 as the package manager, not npm. Always reference yarn commands when suggesting package management operations.
Learnt from: JounQin
PR: alauda/doom#30
File: src/runtime/components/K8sCrd.tsx:5-5
Timestamp: 2025-05-26T09:09:21.339Z
Learning: The alauda/doom project uses yarn v4 for dependency management, which handles package exports and module resolution correctly, so imports like `@rspress/core/theme` work without any ESLint errors.
Learnt from: JounQin
PR: alauda/doom#117
File: src/remark-lint/no-heading-punctuation.ts:4-4
Timestamp: 2025-07-09T02:33:05.638Z
Learning: In the @alauda/doom project, JounQin prefers to keep the `toString` import from `mdast-util-to-string` as is, even though it shadows the global toString property. Variable shadowing warnings for this specific case should not be flagged as issues.
Learnt from: JounQin
PR: alauda/doom#34
File: src/cli/load-config.ts:290-0
Timestamp: 2025-05-29T10:23:34.965Z
Learning: In the @alauda/doom project, JounQin prefers concise error handling over verbose validation. While they prefer throwing on invalid configuration rather than graceful fallbacks, they don't want overly detailed validation with multiple explicit checks and error messages.
Learnt from: JounQin
PR: alauda/doom#117
File: src/remark-lint/constants.ts:1-1
Timestamp: 2025-07-09T02:31:06.588Z
Learning: In the @alauda/doom project, PUNCTUATION_REGEX in src/remark-lint/constants.ts is only used for test() operations, so the global flag is not needed and the current implementation /\p{P}/u is correct.
Learnt from: JounQin
PR: alauda/doom#34
File: src/cli/load-config.ts:290-0
Timestamp: 2025-05-29T10:22:30.004Z
Learning: In the @alauda/doom project, the team prefers throwing descriptive errors for invalid configuration rather than using optional chaining or graceful fallbacks. This fail-fast approach helps catch configuration issues early during development.
styles/global.scss (1)
Learnt from: JounQin
PR: alauda/doom#30
File: src/runtime/components/K8sCrd.tsx:5-5
Timestamp: 2025-05-26T09:09:21.339Z
Learning: The alauda/doom project uses yarn v4 for dependency management, which handles package exports and module resolution correctly, so imports like `@rspress/core/theme` work without any ESLint errors.
🔇 Additional comments (1)
styles/global.scss (1)
72-75: Selector scope tightened – double-check downstream markupSwitching from
> olto> .rp-list-decimalprevents accidental overrides but will drop styling for any callout list that doesn’t get that class. Please verify every generated callout list receives.rp-list-decimal; otherwise the numbered bubbles vanish.If that guarantee is not absolute, consider a fallback:
- > .rp-list-decimal { + > .rp-list-decimal, + > ol {
Summary by CodeRabbit
Bug Fixes
Chores