refactor: use toMarkdownExtensions data instead#140
Conversation
🦋 Changeset detectedLatest commit: 48cc33b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Rate limit exceeded@JounQin has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 57 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the remark-directives plugin to use unified's data mechanism for markdown extensions instead of directly importing and using the directiveToMarkdown function. The change removes the direct dependency on mdast-util-directive and leverages the processor's built-in extension handling.
- Replaces direct
directiveToMarkdown()usage withthis.data('toMarkdownExtensions') - Adds processor settings integration via
this.data('settings') - Removes
mdast-util-directivedependency from package.json
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/plugins/directives/remark-directives.ts | Refactors toMarkdown call to use processor data instead of direct extension import |
| package.json | Removes mdast-util-directive dependency |
Signed-off-by: JounQin <admin@1stg.me>
commit: |
No description provided.