-
Notifications
You must be signed in to change notification settings - Fork 2
test: add rstest unit tests for doom and export packages #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d83cb77
test: add rstest unit tests for doom and export packages
JounQin 2268431
chore: add AGENTS.md knowledge base and OpenSpec scaffolding
JounQin eecaba3
refactor: simplify infra structure
JounQin 9236145
refactor: rename .test.ts files to .spec.ts
JounQin 9533a03
chore: add subpath imports and split lint scripts
JounQin 6cae166
docs: update openspec change artifacts
JounQin 4e7ee58
docs: update AGENTS.md files with rstest unit testing info
JounQin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| --- | ||
| description: Implement tasks from an OpenSpec change (Experimental) | ||
| --- | ||
|
|
||
| Implement tasks from an OpenSpec change. | ||
|
|
||
| **Input**: Optionally specify a change name (e.g., `/opsx-apply add-auth`). If omitted, check if it can be inferred from conversation context. If vague or ambiguous you MUST prompt for available changes. | ||
|
|
||
| **Steps** | ||
|
|
||
| 1. **Select the change** | ||
|
|
||
| If a name is provided, use it. Otherwise: | ||
| - Infer from conversation context if the user mentioned a change | ||
| - Auto-select if only one active change exists | ||
| - If ambiguous, run `openspec list --json` to get available changes and use the **AskUserQuestion tool** to let the user select | ||
|
|
||
| Always announce: "Using change: <name>" and how to override (e.g., `/opsx-apply <other>`). | ||
|
|
||
| 2. **Check status to understand the schema** | ||
|
|
||
| ```bash | ||
| openspec status --change "<name>" --json | ||
| ``` | ||
|
|
||
| Parse the JSON to understand: | ||
| - `schemaName`: The workflow being used (e.g., "spec-driven") | ||
| - Which artifact contains the tasks (typically "tasks" for spec-driven, check status for others) | ||
|
|
||
| 3. **Get apply instructions** | ||
|
|
||
| ```bash | ||
| openspec instructions apply --change "<name>" --json | ||
| ``` | ||
|
|
||
| This returns: | ||
| - Context file paths (varies by schema) | ||
| - Progress (total, complete, remaining) | ||
| - Task list with status | ||
| - Dynamic instruction based on current state | ||
|
|
||
| **Handle states:** | ||
| - If `state: "blocked"` (missing artifacts): show message, suggest using `/opsx-continue` | ||
| - If `state: "all_done"`: congratulate, suggest archive | ||
| - Otherwise: proceed to implementation | ||
|
|
||
| 4. **Read context files** | ||
|
|
||
| Read the files listed in `contextFiles` from the apply instructions output. | ||
| The files depend on the schema being used: | ||
| - **spec-driven**: proposal, specs, design, tasks | ||
| - Other schemas: follow the contextFiles from CLI output | ||
|
|
||
| 5. **Show current progress** | ||
|
|
||
| Display: | ||
| - Schema being used | ||
| - Progress: "N/M tasks complete" | ||
| - Remaining tasks overview | ||
| - Dynamic instruction from CLI | ||
|
|
||
| 6. **Implement tasks (loop until done or blocked)** | ||
|
|
||
| For each pending task: | ||
| - Show which task is being worked on | ||
| - Make the code changes required | ||
| - Keep changes minimal and focused | ||
| - Mark task complete in the tasks file: `- [ ]` → `- [x]` | ||
| - Continue to next task | ||
|
|
||
| **Pause if:** | ||
| - Task is unclear → ask for clarification | ||
| - Implementation reveals a design issue → suggest updating artifacts | ||
| - Error or blocker encountered → report and wait for guidance | ||
| - User interrupts | ||
|
|
||
| 7. **On completion or pause, show status** | ||
|
|
||
| Display: | ||
| - Tasks completed this session | ||
| - Overall progress: "N/M tasks complete" | ||
| - If all done: suggest archive | ||
| - If paused: explain why and wait for guidance | ||
|
|
||
| **Output During Implementation** | ||
|
|
||
| ``` | ||
| ## Implementing: <change-name> (schema: <schema-name>) | ||
|
|
||
| Working on task 3/7: <task description> | ||
| [...implementation happening...] | ||
| ✓ Task complete | ||
|
|
||
| Working on task 4/7: <task description> | ||
| [...implementation happening...] | ||
| ✓ Task complete | ||
| ``` | ||
|
|
||
| **Output On Completion** | ||
|
|
||
| ``` | ||
| ## Implementation Complete | ||
|
|
||
| **Change:** <change-name> | ||
| **Schema:** <schema-name> | ||
| **Progress:** 7/7 tasks complete ✓ | ||
|
|
||
| ### Completed This Session | ||
| - [x] Task 1 | ||
| - [x] Task 2 | ||
| ... | ||
|
|
||
| All tasks complete! You can archive this change with `/opsx-archive`. | ||
| ``` | ||
|
|
||
| **Output On Pause (Issue Encountered)** | ||
|
|
||
| ``` | ||
| ## Implementation Paused | ||
|
|
||
| **Change:** <change-name> | ||
| **Schema:** <schema-name> | ||
| **Progress:** 4/7 tasks complete | ||
|
|
||
| ### Issue Encountered | ||
| <description of the issue> | ||
|
|
||
| **Options:** | ||
| 1. <option 1> | ||
| 2. <option 2> | ||
| 3. Other approach | ||
|
|
||
| What would you like to do? | ||
| ``` | ||
|
|
||
| **Guardrails** | ||
|
|
||
| - Keep going through tasks until done or blocked | ||
| - Always read context files before starting (from the apply instructions output) | ||
| - If task is ambiguous, pause and ask before implementing | ||
| - If implementation reveals issues, pause and suggest artifact updates | ||
| - Keep code changes minimal and scoped to each task | ||
| - Update task checkbox immediately after completing each task | ||
| - Pause on errors, blockers, or unclear requirements - don't guess | ||
| - Use contextFiles from CLI output, don't assume specific file names | ||
|
|
||
| **Fluid Workflow Integration** | ||
|
|
||
| This skill supports the "actions on a change" model: | ||
|
|
||
| - **Can be invoked anytime**: Before all artifacts are done (if tasks exist), after partial implementation, interleaved with other actions | ||
| - **Allows artifact updates**: If implementation reveals design issues, suggest updating artifacts - not phase-locked, work fluidly | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,156 @@ | ||
| --- | ||
| description: Archive a completed change in the experimental workflow | ||
| --- | ||
|
|
||
| Archive a completed change in the experimental workflow. | ||
|
|
||
| **Input**: Optionally specify a change name after `/opsx-archive` (e.g., `/opsx-archive add-auth`). If omitted, check if it can be inferred from conversation context. If vague or ambiguous you MUST prompt for available changes. | ||
|
|
||
| **Steps** | ||
|
|
||
| 1. **If no change name provided, prompt for selection** | ||
|
|
||
| Run `openspec list --json` to get available changes. Use the **AskUserQuestion tool** to let the user select. | ||
|
|
||
| Show only active changes (not already archived). | ||
| Include the schema used for each change if available. | ||
|
|
||
| **IMPORTANT**: Do NOT guess or auto-select a change. Always let the user choose. | ||
|
|
||
| 2. **Check artifact completion status** | ||
|
|
||
| Run `openspec status --change "<name>" --json` to check artifact completion. | ||
|
|
||
| Parse the JSON to understand: | ||
| - `schemaName`: The workflow being used | ||
| - `artifacts`: List of artifacts with their status (`done` or other) | ||
|
|
||
| **If any artifacts are not `done`:** | ||
| - Display warning listing incomplete artifacts | ||
| - Prompt user for confirmation to continue | ||
| - Proceed if user confirms | ||
|
|
||
| 3. **Check task completion status** | ||
|
|
||
| Read the tasks file (typically `tasks.md`) to check for incomplete tasks. | ||
|
|
||
| Count tasks marked with `- [ ]` (incomplete) vs `- [x]` (complete). | ||
|
|
||
| **If incomplete tasks found:** | ||
| - Display warning showing count of incomplete tasks | ||
| - Prompt user for confirmation to continue | ||
| - Proceed if user confirms | ||
|
|
||
| **If no tasks file exists:** Proceed without task-related warning. | ||
|
|
||
| 4. **Assess delta spec sync state** | ||
|
|
||
| Check for delta specs at `openspec/changes/<name>/specs/`. If none exist, proceed without sync prompt. | ||
|
|
||
| **If delta specs exist:** | ||
| - Compare each delta spec with its corresponding main spec at `openspec/specs/<capability>/spec.md` | ||
| - Determine what changes would be applied (adds, modifications, removals, renames) | ||
| - Show a combined summary before prompting | ||
|
|
||
| **Prompt options:** | ||
| - If changes needed: "Sync now (recommended)", "Archive without syncing" | ||
| - If already synced: "Archive now", "Sync anyway", "Cancel" | ||
|
|
||
| If user chooses sync, use Task tool (subagent_type: "general-purpose", prompt: "Use Skill tool to invoke openspec-sync-specs for change '<name>'. Delta spec analysis: <include the analyzed delta spec summary>"). Proceed to archive regardless of choice. | ||
|
|
||
| 5. **Perform the archive** | ||
|
|
||
| Create the archive directory if it doesn't exist: | ||
|
|
||
| ```bash | ||
| mkdir -p openspec/changes/archive | ||
| ``` | ||
|
|
||
| Generate target name using current date: `YYYY-MM-DD-<change-name>` | ||
|
|
||
| **Check if target already exists:** | ||
| - If yes: Fail with error, suggest renaming existing archive or using different date | ||
| - If no: Move the change directory to archive | ||
|
|
||
| ```bash | ||
| mv openspec/changes/<name> openspec/changes/archive/YYYY-MM-DD-<name> | ||
| ``` | ||
|
|
||
| 6. **Display summary** | ||
|
|
||
| Show archive completion summary including: | ||
| - Change name | ||
| - Schema that was used | ||
| - Archive location | ||
| - Spec sync status (synced / sync skipped / no delta specs) | ||
| - Note about any warnings (incomplete artifacts/tasks) | ||
|
|
||
| **Output On Success** | ||
|
|
||
| ``` | ||
| ## Archive Complete | ||
|
|
||
| **Change:** <change-name> | ||
| **Schema:** <schema-name> | ||
| **Archived to:** openspec/changes/archive/YYYY-MM-DD-<name>/ | ||
| **Specs:** ✓ Synced to main specs | ||
|
|
||
| All artifacts complete. All tasks complete. | ||
| ``` | ||
|
|
||
| **Output On Success (No Delta Specs)** | ||
|
|
||
| ``` | ||
| ## Archive Complete | ||
|
|
||
| **Change:** <change-name> | ||
| **Schema:** <schema-name> | ||
| **Archived to:** openspec/changes/archive/YYYY-MM-DD-<name>/ | ||
| **Specs:** No delta specs | ||
|
|
||
| All artifacts complete. All tasks complete. | ||
| ``` | ||
|
|
||
| **Output On Success With Warnings** | ||
|
|
||
| ``` | ||
| ## Archive Complete (with warnings) | ||
|
|
||
| **Change:** <change-name> | ||
| **Schema:** <schema-name> | ||
| **Archived to:** openspec/changes/archive/YYYY-MM-DD-<name>/ | ||
| **Specs:** Sync skipped (user chose to skip) | ||
|
|
||
| **Warnings:** | ||
| - Archived with 2 incomplete artifacts | ||
| - Archived with 3 incomplete tasks | ||
| - Delta spec sync was skipped (user chose to skip) | ||
|
|
||
| Review the archive if this was not intentional. | ||
| ``` | ||
|
|
||
| **Output On Error (Archive Exists)** | ||
|
|
||
| ``` | ||
| ## Archive Failed | ||
|
|
||
| **Change:** <change-name> | ||
| **Target:** openspec/changes/archive/YYYY-MM-DD-<name>/ | ||
|
|
||
| Target archive directory already exists. | ||
|
|
||
| **Options:** | ||
| 1. Rename the existing archive | ||
| 2. Delete the existing archive if it's a duplicate | ||
| 3. Wait until a different date to archive | ||
| ``` | ||
|
|
||
| **Guardrails** | ||
|
|
||
| - Always prompt for change selection if not provided | ||
| - Use artifact graph (openspec status --json) for completion checking | ||
| - Don't block archive on warnings - just inform and confirm | ||
| - Preserve .openspec.yaml when moving to archive (it moves with the directory) | ||
| - Show clear summary of what happened | ||
| - If sync is requested, use the Skill tool to invoke `openspec-sync-specs` (agent-driven) | ||
| - If delta specs exist, always run the sync assessment and show the combined summary before prompting |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.