feat(Storage): async partition scan with 'ready' event (Option B)#303
Draft
feat(Storage): async partition scan with 'ready' event (Option B)#303
Conversation
…r Storage Agent-Logs-Url: https://github.com/albe/node-event-storage/sessions/2aa87f92-de57-4e81-adbb-8dcdafb33cec Co-authored-by: albe <4259532+albe@users.noreply.github.com>
Agent-Logs-Url: https://github.com/albe/node-event-storage/sessions/2aa87f92-de57-4e81-adbb-8dcdafb33cec Co-authored-by: albe <4259532+albe@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Implement option B for hierarchical stream names based on review feedback
feat(Storage): async partition scan with 'ready' event (Option B)
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage initialization was synchronous (
scanForFilesSyncin constructor), unlike EventStore's async'ready'pattern. This implements Option B: partition scanning is now async, and Storage emits'ready'once both the scan andopen()have completed.Core changes
ReadableStorage:scanPartitions()uses asyncscanForFiles();_emitReadyIfConditionsMet()fires'ready'when both_scanDoneand_openedare true;close()resets_openedso'ready're-fires on the nextopen()WritableStorage: removes synchronousthis.emit('ready')fromopen(); deferscheckTornWrites()forLOCK_RECLAIM(via_needsRepairflag) to just before'ready'fires, via an override of_emitReadyIfConditionsMet()EventStore.initialize(): registersstorage.on('ready', ...)before callingscanStreams(), socheckUnfinishedCommits()only runs after all partitions are loadedutil.scanForFiles(): handlesENOENTgracefully on non-root subdirectories to survive transient lock-directory deletion during scanningNew caller contract
New writes and in-session reads work immediately (new partitions are created on demand). Only reading data from a previous session requires waiting for
'ready'. Re-opening the same instance re-emits'ready'synchronously (scan already done).Test impact
Six
Storage.spec.jstests that created a newStorageon existing data were updated to the'ready'pattern. TheLOCK_RECLAIMtest's synchronousreadyFiredassertion was removed since repair is now deferred to just before async'ready'.