Skip to content

Fixed AutomaticallyEquatable Object Recursion#3

Merged
albertbori merged 1 commit intomainfrom
recursion-fix
Feb 10, 2023
Merged

Fixed AutomaticallyEquatable Object Recursion#3
albertbori merged 1 commit intomainfrom
recursion-fix

Conversation

@albertbori
Copy link
Copy Markdown
Owner

This PR introduces a fix to AutomaticallyEquatable which allows objects with recursive relationship to be compared for equality. It relies on referential equality to prevent recursion while still comparing all members of reference types if referential equality fails.

Other Additions

  • Added unit tests to ensure the functionality of several recursive reference scenarios
  • Added unit tests to ensure Error <-> objc NSError auto-conversion properties don't cause recursion problems
  • Prevented intentional example unit test failure from breaking (future support for) CI builds
  • Updated documentation to remove the warning about recursive relationships

@albertbori albertbori merged commit 38d345b into main Feb 10, 2023
@albertbori albertbori deleted the recursion-fix branch February 10, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant