[QBM] Add background color for highlight_color

[dreamcat4]

• CHECK FOR EXISTING ISSUES, ALSO CLOSED ONES!
  yes

Description

With orignal Widget Box Model, then the selected highlighted choice is given a different background color. It would be nice to see this feature also with QML Box Model too 👍

Expected behavior

The selected item has background color change.

Steps to reproduce

• Select QML Box Model in settings
• Open theme PropertyEditor
• Look for the following theme color setting: highlight_color - it exists! But that is the foreground text color
• The foreground text color is too hard to see, from a distance
• Look for the following theme color setting: highlight_color_bg - doesnt exists! ..but it would solve the problem

Screenshots

Problem:

QML Box Model (new style)

Solution:

Widget Box model (old style)

Additional information (please provide the following information):

albert 0.17.2

installed today from obs software repo (ubuntu 21.04) like this:

echo 'deb http://download.opensuse.org/repositories/home:/manuelschneid3r/xUbuntu_21.04/ /' | sudo tee /etc/apt/sources.list.d/home:manuelschneid3r.list
curl -fsSL https://download.opensuse.org/repositories/home:manuelschneid3r/xUbuntu_21.04/Release.key | gpg --dearmor | sudo tee /etc/apt/trusted.gpg.d/home_manuelschneid3r.gpg > /dev/null
sudo apt update
sudo apt install albert

Details

$ albert --report
core:         Albert version: 0.17.2
core:             Build date: Oct 29 2017 00:00:00
core:             Qt version: 5.15.2
core:   QT_QPA_PLATFORMTHEME: qt5ct
core:        Binary location: /usr/bin/albert
core:                    PWD: /home/id/.bin
core:                  SHELL: /bin/bash
core:                   LANG: en_GB.UTF-8
core:       XDG_SESSION_TYPE: x11
core:    XDG_CURRENT_DESKTOP: Budgie:GNOME
core:        DESKTOP_SESSION: budgie-desktop
core:    XDG_SESSION_DESKTOP: budgie-desktop
core:                     OS: Ubuntu 21.04
core:      OS (type/version): ubuntu/21.04
core:              Build ABI: x86_64-little_endian-lp64
core:   Arch (build/current): x86_64/x86_64
core:  Kernel (type/version): linux/5.11.14-051114-lowlatency

Output of `albert` when started in a terminal (stdout/stderr)

$ albert
19:28:03 [info:core] Initializing application
19:28:04 [info:default] Systems icon theme is: "Surfn-Evopop"
19:28:04 [debg:default] Icon theme "Surfn-Evopop" not found.
19:28:04 [info:core] Initializing mandatory paths
19:28:04 [info:core] Setup signal handlers
19:28:04 [info:core] Creating running indicator file
19:28:04 [info:core] Initializing core components
19:28:04 [warn:default] file:///usr/share/albert/org.albert.frontend.qmlboxmodel/styles/BoxModel/MainComponent.qml:275:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
19:28:04 [warn:default] file:///usr/share/albert/org.albert.frontend.qmlboxmodel/styles/BoxModel/DesktopListView.qml:16:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
19:28:04 [warn:default] file:///usr/share/albert/org.albert.frontend.qmlboxmodel/styles/BoxModel/DesktopListView.qml:16:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
19:28:04 [info:core] Loading extension org.albert.extension.applications
19:28:04 [info:apps] Start indexing applications.
19:28:04 [debg:core] org.albert.extension.applications loaded in 0 milliseconds
19:28:04 [info:core] Loading extension org.albert.extension.calculator
19:28:04 [debg:core] org.albert.extension.calculator loaded in 3 milliseconds
19:28:04 [info:core] Loading extension org.albert.extension.files
19:28:04 [debg:applications] Loading file index from cache.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[moodboom]

Related: I don't know why but with the Widget Box Model I cannot see any highlight on the selected item. It's very confusing as you can't tell what you will select on Enter. And with QML box model, the highlight is done with a "pushed button" effect that does not follow the selection well as you use up/down arrow (old highllights are left and new are not added as you navigate). Thanks for this!

Update: if i look VERY closely there is a TINY shading on the selected item - it is not enough on my system for me to naturally
see the selection.

[ManuelSchneid3r]

revamped