Skip to content

chore: Documentation fixes and minor API update#10

Merged
albertodev01 merged 3 commits intomasterfrom
chore/api_improvements
Apr 17, 2021
Merged

chore: Documentation fixes and minor API update#10
albertodev01 merged 3 commits intomasterfrom
chore/api_improvements

Conversation

@albertodev01
Copy link
Owner

Why?

There are some small error in the documentation and some missing methods to convert fraction classes to the new EgyptianFraction type.

What?

Added toEgyptianFraction methods and fixed some minor documentation mistakes.

Types of Changes

  • New feature (non-breaking change which adds functionality) -->
  • Documentation change

Checklist

  • I have provided a description of the proposed changes.
  • I added unit tests for all relevant code.
  • I added golden tests for all UI changes.
  • I added documentation for all relevant code.

@albertodev01 albertodev01 added Documentation Improvements or additions to documentation enhancement labels Apr 17, 2021
@albertodev01 albertodev01 self-assigned this Apr 17, 2021
@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #10 (9fd7ba1) into master (456e342) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          299       305    +6     
=========================================
+ Hits           299       305    +6     
Impacted Files Coverage Δ
lib/src/extensions/fraction_string.dart 100.00% <ø> (ø)
lib/src/utils/exceptions.dart 100.00% <ø> (ø)
lib/src/core.dart 100.00% <100.00%> (ø)
lib/src/egyptian.dart 100.00% <100.00%> (ø)
lib/src/mixed.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 456e342...9fd7ba1. Read the comment docs.

@albertodev01 albertodev01 merged commit 461fab0 into master Apr 17, 2021
@albertodev01 albertodev01 deleted the chore/api_improvements branch April 17, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant