Skip to content
This repository was archived by the owner on Nov 13, 2019. It is now read-only.

Conversation

@alcarney
Copy link
Owner

No description provided.

- Added dedicated error handling code. Each error is assigned a code
  given a short description and will provide a link to the troubleshooting
  page on the docs.
- Added a vertex array abstract class which handles most of business of
  handling an array of vertices.
- Added specific implementations of the abstract class `Cartesian` and
  `Cylindrical` which handle the coordinate system specific conversions

- Deleted most of the existing Mesh code while I figure out what is going to
  happen with these vertex arrays
- This will give us the control needed to add the interactive
  three.js model previews that we want!
- We might be able to add our own custom directives etc. that will also
  allow us to implement the "level of knowledge" that I've been thinking
  about
- Best of all it hopefully looks good
- A proof of concept flat plane has been "hard coded" into the reference
  page for that primitive.
- Started work on a custom Sphinx directive that will make adding models to
  the web page feasable
- Given a name, obj and mtl the new ..showmodel:: directive will embed the
  code required to load and preview the model in the browser
- Made steps towards making the new theme responsive
- Added individual coordinate properties for each supported coordinate variable
- Added a __getitem__ method to :code:`VertexArray` ready for us to implement
  adding functions
- Docs are still chugging along as well
- Don't forget the tests!
- Coordinate properties can now be assined functions! E.g. to apply a height
  dependent twist to an object can now be as easy as
  :code:`vertices.t = lambda t, z: t + 0.3*z`
@coveralls
Copy link

coveralls commented Mar 21, 2018

Pull Request Test Coverage Report for Build 30

  • 186 of 294 (63.27%) changed or added relevant lines in 9 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+4.6%) to 58.919%

Changes Missing Coverage Covered Lines Changed/Added Lines %
topos/generators.py 1 5 20.0%
topos/errors.py 10 18 55.56%
topos/primitives.py 7 18 38.89%
topos/mesh.py 13 28 46.43%
topos/faces.py 27 44 61.36%
topos/vertices.py 120 173 69.36%
Files with Coverage Reduction New Missed Lines %
topos/mesh.py 2 54.05%
Totals Coverage Status
Change from base Build 9: 4.6%
Covered Lines: 218
Relevant Lines: 370

💛 - Coveralls

@alcarney alcarney merged commit 4a83da9 into master Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants