[OpenRPC] Fix eth_getFinalizedHeader example with realistic BNB data and proper schema#1187
Merged
SahilAujla merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
…and proper schema - Replace placeholder values (0xabc123...) with real BNB mainnet block header data - Add all 23 header fields to the example (was only 3) - Add verifiedValidatorNum param (method requires it per BSC docs) - Add proper description explaining finality threshold shortcuts - Replace loose additionalProperties:true schema with typed properties using to existing base-types (hash32, uint, address, bytes, etc.)
🔗 Preview Mode
|
🔍 Link CheckStatus: ⏭️ Skipped (no content changes) |
SahilAujla
approved these changes
Apr 7, 2026
dslovinsky
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes DOCS-34: The
eth_getFinalizedHeadermethod definition had placeholder example values and an incomplete schema.Changes
Example data
0xabc123...,0x123456,0xdef456...) with real BNB mainnet block header dataverifiedValidatorNum: -3param to example (the method requires this parameter)Method definition
verifiedValidatorNumparameter with description explaining the finality threshold shortcuts (-1, -2, -3)Result schema
type: object+additionalProperties: truewith fully typed properties$refto existing base-types (hash32, uint, address, bytes, bytes8, bytes256)Validation
pnpm run validate:rpc✅pnpm run generate:rpc✅