Fix rrule bug regarding daylight saving time#404
Merged
aldabil21 merged 1 commit intoaldabil21:masterfrom Nov 12, 2024
Merged
Conversation
Owner
|
Thank you @marcauberer looks good |
Contributor
|
@aldabil21 Was this fix ever released? It looks like the last release was on Sept 5? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes a bug, that originated from a wrong usage of rrule. The documentation states, that rrule should be fed with UTC dates only (see here).
E.g. in Germany we have the timezone "Europe/Berlin" which is UTC+2 in summer and UTC+1 in winter (as of october 27th). RRule produced something like:
The expected is:
This should be fixed with this patch. It was inspired by this GitHub issue reply.