Avoid creating unaligned ref in H5Type derive macro #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulimoen
reviewed
May 29, 2023
hdf5-derive/src/lib.rs
Outdated
| ty: <#types as _h5::types::H5Type>::type_descriptor(), | ||
| offset: unsafe { &((*origin).#fields) as *const _ as _ }, | ||
| offset: unsafe { | ||
| ::std::ptr::addr_of!((*origin_ptr).#fields) as usize - origin_ptr as usize |
Collaborator
There was a problem hiding this comment.
Maybe offset_from with the pointers cast to u8 pointers?
Collaborator
There was a problem hiding this comment.
Prefer .cast::<u8>() over as
rytheo
force-pushed
the
avoid-unaligned-ref
branch
2 times, most recently
from
aae9267 to
cf5306f
Compare
rytheo
force-pushed
the
avoid-unaligned-ref
branch
from
cf5306f to
90bd2ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating unaligned references now causes a compile-time error, so this change uses
std::ptr::addr_of!to compute struct field offsets instead.