Implement Send+Sync for VarLenAscii/Unicode/Array #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulimoen
requested changes
Feb 13, 2024
Collaborator
mulimoen
left a comment
mulimoen
left a comment
There was a problem hiding this comment.
Minor adjustments to the comments aside, this looks good to go!
Co-authored-by: Magnus Ulimoen <mulimoen@users.noreply.github.com> Signed-off-by: Craig Watson <686868+watsaig@users.noreply.github.com>
Contributor
Author
|
Thank you for the review! |
mulimoen
approved these changes
Feb 13, 2024
Collaborator
|
Thank you for implementing this @watsaig! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #269
@mulimoen Thank you for the feedback. I have added Send + Sync to the
VarLen...types including comments to justify that (hopefully accurately).