Skip to content

Implement Send+Sync for VarLenAscii/Unicode/Array #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Implement Send+Sync for VarLenAscii/Unicode/Array #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2a88b
Implement Send+Sync for VarLenAscii/Unicode/Array
watsaig Feb 7, 2024
1455a77
Apply suggestions from review
watsaig Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions hdf5-types/src/array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@ impl<T: Copy + fmt::Debug> fmt::Debug for VarLenArray<T> {
}
}

// Safety: Memory backed by `VarLenArray` can be accessed and freed from any thread
unsafe impl<T: Copy + Send> Send for VarLenArray<T> {}
// Safety: `VarLenArray` has no interior mutability
unsafe impl<T: Copy + Sync> Sync for VarLenArray<T> {}

#[cfg(test)]
pub mod tests {
use super::VarLenArray;
Expand Down
10 changes: 10 additions & 0 deletions hdf5-types/src/string.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@ impl AsAsciiStr for VarLenAscii {
}
}

// Safety: Memory backed by `VarLenAscii` can be accessed and freed from any thread
unsafe impl Send for VarLenAscii {}
// Safety: `VarLenAscii` has no interior mutability
unsafe impl Sync for VarLenAscii {}

// ================================================================================

#[repr(C)]
Expand Down Expand Up @@ -371,6 +376,11 @@ impl FromStr for VarLenUnicode {
}
}

// Safety: Memory backed by `VarLenUnicode` can be accessed and freed from any thread
unsafe impl Send for VarLenUnicode {}
// Safety: `VarLenUnicode` has no interior mutability
unsafe impl Sync for VarLenUnicode {}

// ================================================================================

#[repr(C)]
Expand Down