Skip to content

Editor refactoring mode#11

Closed
hleb-rubanau wants to merge 47 commits into
aldum:masterfrom
hleb-rubanau:features/editor_refactoring_mode
Closed

Editor refactoring mode#11
hleb-rubanau wants to merge 47 commits into
aldum:masterfrom
hleb-rubanau:features/editor_refactoring_mode

Conversation

@hleb-rubanau
Copy link
Copy Markdown
Collaborator

@hleb-rubanau hleb-rubanau commented Mar 23, 2026

This change solves compy-toys#115 introducing "refactoring mode"

Some work is still pending -- going to add tests, and probably check the code against style conventions.

But the supposed logic can be reviewed already.

@hleb-rubanau hleb-rubanau marked this pull request as draft March 23, 2026 19:59
@hleb-rubanau hleb-rubanau force-pushed the features/editor_refactoring_mode branch from d48170e to 0534da2 Compare March 23, 2026 20:27
@hleb-rubanau hleb-rubanau marked this pull request as ready for review March 23, 2026 21:19
aldum and others added 5 commits April 7, 2026 23:01
@aldum
refactor: compy namespace
cf94d7e
@aldum
feat: add configurable cursor blinking compy-toys#123
bd84a1f
@Vadim1987
feat: add compy.graphics with bezier polygonization and shape renderi…
8647cbf 
…ng (#12)

* feat: add compy.graphics with bezier polygonization and shape rendering
* review: weak caches, shape2d under compy.graphics.shape2d

---------

Co-authored-by: Vadym <vadym@MacBook-Pro-Vadym.local>
@aldum
Feature/enable stencil buffer (#13)
66fc0ef 
* feat: enable stencil buffer for user canvas
@aldum
chore(ci): disable release APKs unless on special tag
618b23e
aldum
aldum requested changes Apr 12, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@aldum aldum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the number of conttributors is spiking, I'm rethinking the branching strategy. We will be working against dev, please rebase the PR against it.

Another thing I'd like see codebase-wide (meaning I need to clean up some of my older work too) is type annotations for all public classes and functions. In the case of this PR, EditorSession is a prominent example, it would aid in communicating intent to the reader immensely.

Other than that, good quality code, I really appreciate the usage of my table utilities :)

Comment thread src/controller/editorController.lua Outdated
Comment thread src/view/editor/bufferView.lua Outdated
Comment thread src/controller/editorController.lua
Comment thread src/controller/editorController.lua Outdated
Comment thread src/model/editor/bufferModel.lua Outdated
Comment thread tests/helpers/editor_session.lua Outdated
Comment thread tests/helpers/editor_session.lua Outdated
Comment thread tests/editor/editor_spec.lua
aldum and others added 21 commits April 23, 2026 00:26
@aldum
refactor: consistently call ConController CC
30d2fb4
@aldum
feat: make loadfile() work in projects compy-toys#128
64a0cd9
@aldum
refactor: use handler wrapper from CC
2c5b622
@aldum
fix(clock): properly draw background
b54fbb3
@aldum
refactor: use period to configure blink
62e9c09
@aldum
feat(debug): add fire_noted
03ec929
@aldum
feat: add sapper
918c87f
@aldum
refactor(doc): cleanup shellcheck warnings
6b6374c
@hleb-rubanau
fix(views/userInput): crash on space typed [compy-toys#131] (#14)
3219d9c 
Stricter check for actual presence of error lines in 'parsed error' container

Closes: compy-toys#131
@hleb-rubanau
feat(editor): allow monster blocks to be edited/saved if selection st…
bb6ddfe 
…art is visible
@hleb-rubanau
fix(editor/buffer): as part of submit preprocesing, enforce newlines …
c68c4ad 
…between non-empty pretty blocks if there is more than one block
@hleb-rubanau
feat(editor): scroll into first oversized block if in refactoring mode
09c0074
@hleb-rubanau
fix(editor/replace): restrict reopening oversized blocks to lua only
b96c3b6
@hleb-rubanau
fix(editor/buffer): function breaking when optional arg not provided
273822b
@hleb-rubanau
feat(editor): refactoring mode reorganized -- only partial saves, ove…
1477505 
…esized blocks are ephemeral
@hleb-rubanau
fix(editor): visibility check should always be oversize-tolerant
7ccb8cf
@hleb-rubanau
chore(tests): simple test for code editing
49063d8
@hleb-rubanau
chore(tests/editor/blocks): simple test refactored to use helpers
ad019c8
@hleb-rubanau
chore(tests/editor): rescope
ae08ea8
@hleb-rubanau
chore(tests/editor): rescope
e617aca
@hleb-rubanau
chore(tests/editor): rescope and add basic test for block addition
4b4304a
hleb-rubanau added 21 commits May 17, 2026 18:41
@hleb-rubanau
chore(editor/tests): more test cases
848f359
@hleb-rubanau
chore(tests/editor): coverage for work with blocks (4 cases pending)
48461eb
@hleb-rubanau
fix(editor): reject non-refactorable oversize edit
cf4cc41
@hleb-rubanau
chore(tests): context isolation
7f91b48 
All context variables need hard resets before each test
(sharing controller object without cleanup -> cursor chaos)
@hleb-rubanau
chore(tests): assert cosmetics
477c7ed
@hleb-rubanau
chore(tests): unpend 2 cases (1 ok. 1 fails) + more assertion cosmetics
03ea176
@hleb-rubanau
fix(editor): tests and multiline handing for insertion (3 tests still…
a59ac13 
… failing)
@hleb-rubanau
chore(tests): typo in replacement test case
e218dd4
@hleb-rubanau
fix(editor): refresh view before moving selection
e512cf3
@hleb-rubanau
fix(editor/blocks): account for emptyline collapses on injection
7eb463d
@hleb-rubanau
chore(tests): improve comments
81cf3a2
@hleb-rubanau
chore(tests/editor_session): autoformat test file
1bf1b15 
Conservatively setting col=65 to match editor's own conventions
@hleb-rubanau
chore(tests/editor): just declare vars at describe() level, no setup(…
ed26253 
…) involved
@hleb-rubanau
chore(controller/editor): use is_empty() istead of low-level tag check
3ac5d60
@hleb-rubanau
chore(editor): avoid direct access to chunk lines, use :to_lines() wr…
94898b2 
…apper instead
@hleb-rubanau
chore(views/bufferVIew): more correct naming of size function (get_si…
2f20d16 
…ze -> get_max_size)
@hleb-rubanau
chore(spec): clarify comment even more
7938b08
@hleb-rubanau
chore(test/helpers/codesnippets): linter
801f16c
@hleb-rubanau
chore: annotate new and altered functions
d85ab04
@hleb-rubanau
fix(editor): clear input after block insert
68c3dc5
@hleb-rubanau
fix(editor): strict rejection of oversized input (drop previous parti…
930ce70 
…al toleration)
@hleb-rubanau hleb-rubanau force-pushed the features/editor_refactoring_mode branch from 75f9103 to 930ce70 Compare May 18, 2026 14:22
@hleb-rubanau hleb-rubanau requested a review from aldum May 18, 2026 14:24
@hleb-rubanau
Copy link
Copy Markdown
Collaborator Author

hleb-rubanau commented May 18, 2026

All requested concerns addressed (lintering, annotations, function naming, etc.).

Plus few tweaks done addressing issues communicated beyond github:

  1. Stricter rejection behavior (no partial save, always reject when oversized block is present)
  2. Input cleared after successful insertion, in a same way as after succcesful replacement

@hleb-rubanau hleb-rubanau mentioned this pull request May 25, 2026
Merged
@aldum
Copy link
Copy Markdown
Owner

aldum commented May 25, 2026

Rebased and refactored for demonstration in #16, will merge that one.

@aldum aldum closed this May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aldum aldum Awaiting requested review from aldum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hleb-rubanau @aldum @Vadim1987