Merged
Conversation
Owner
|
Hi @ys-clarry, Thank you for your contribution! It looks good to me. Only you should delete |
Contributor
Author
|
Hello @ale94mleon, Thanks for reviewing. I’ve removed js files and restored the README to original state (To avoid confusion; I forgot to make a separate branch). Please let me know if there’s anything else I should address. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for this great component! Unfortunately, it wasn’t compatible with the latest version of Streamlit, so I’ve made a few updates:
Changed the jsme‑react to @loschmidt's one
Migrated the frontend to TypeScript
Added configurable props for width, height, and other settings
If everything looks good on your end, please feel free to (edit and) merge. Thanks!