Skip to content

Require window-state plugin with size fix#131

Merged
alecdotdev merged 1 commit intoalecdotdev:masterfrom
wargoblin:fix/window-state-shrink
May 7, 2026
Merged

Require window-state plugin with size fix#131
alecdotdev merged 1 commit intoalecdotdev:masterfrom
wargoblin:fix/window-state-shrink

Conversation

@wargoblin
Copy link
Copy Markdown
Contributor

Summary

  • Require tauri-plugin-window-state versions that include the upstream fix for the Windows window-size drift regression.
  • Keep the existing lockfile resolution on 2.4.1 while making the lower bound explicit as >=2.2.2, <3.

Fixes #98

Test plan

  • cargo metadata --locked --format-version 1 --no-deps --manifest-path src-tauri/Cargo.toml shows tauri-plugin-window-state requirement >=2.2.2, <3
  • npm run check
  • cd src-tauri && cargo check
  • cd src-tauri && cargo test

Reviewed with Codex and Copilot in wargoblin#6 before submission.

Copilot AI review requested due to automatic review settings May 6, 2026 07:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the tauri-plugin-window-state dependency constraint to ensure Markpad pulls a plugin version that includes the upstream fix for the Windows window-size drift regression described in issue #98, while keeping compatibility within the Tauri v2 plugin major version range.

Changes:

  • Update tauri-plugin-window-state from a broad "2" requirement to an explicit ">=2.2.2, <3" semver range.
  • Remove trailing blank lines at the end of src-tauri/Cargo.toml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wargoblin
Copy link
Copy Markdown
Contributor Author

Hey @alecdotdev, this is a small dependency-bound PR for #98. The existing window-state setup is already centralized in the Tauri plugin wiring, so I kept this scoped to the Cargo requirement instead of touching runtime window code.

The upstream Tauri plugin release notes identify window-state v2.2.2 as the fix for windows getting bigger/smaller on different monitor scaling. This PR makes Markpad require >=2.2.2, <3 while keeping the current lockfile resolution on 2.4.1.

Pre-submit checklist:

  • Rebased on latest master
  • One squashed commit
  • npm run check clean: 0 errors, existing warnings only
  • Rust compiles cleanly enough for CI (cargo check; existing APP_NAME warning only)
  • Rust tests passing (cargo test; 0 tests)
  • Upstream CI test passed
  • Codex review — 1 dependency-semantics comment addressed; follow-up found no major issues (review PR)
  • Copilot review — 1 dependency-semantics comment addressed; follow-up generated no new comments

Happy to adjust the version range or approach if you prefer an exact pin or a different dependency policy.

@alecdotdev
Copy link
Copy Markdown
Owner

perfect!

@alecdotdev alecdotdev merged commit 60e7bdd into alecdotdev:master May 7, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Window size gets smaller with each consecutive launch

3 participants