fix: make sure the find do not skip CODE and PRE areas.#152
Merged
Conversation
The find did not find text in those area editors before, with this fix, it does.
There was a problem hiding this comment.
Pull request overview
Removes CODE and PRE from the list of skipped elements in the find bar's text walker, so that text inside code/pre blocks (including highlight.js-tokenized content) is now searchable. A clarifying comment is added explaining the rationale for which elements remain skipped.
Changes:
- Allow find to traverse into
<code>and<pre>elements. - Document why
SCRIPT/STYLE/NOSCRIPTand find marks remain skipped.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alecdotdev
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The find did not find text in those area editors before, with this fix, it does.