Feature/add releases generation#5
Merged
Merged
Conversation
aleksisch
added a commit
that referenced
this pull request
Jun 26, 2025
Feature/add releases generation
aleksisch
pushed a commit
that referenced
this pull request
Apr 29, 2026
Fixes 7 review comments in one push: * MCP stdio safety (#1, #5): read_import and compile_and_collect both print warnings/failures to stdout, which corrupts the JSON-RPC protocol stream when called from the MCP server. Add `quiet : bool = false` to both helpers (default preserves CLI behavior); MCP find_duplicates passes true and surfaces failure counts via the returned envelope. * Test portability (#2, #3): replace hard-coded /tmp/... corpus path in test_find_duplicates_corpus_not_found with create_temp_file_result + immediate remove() — guaranteed-nonexistent path that works on Windows runners. * Newline-delimited paths (#4): MCP do_find_duplicates now normalizes \n to , before parse_file_list, matching the README's documented "git diff --name-only | …" pipeline use case. * Project (.das_project) plumbing (#6): add `project` to the find_duplicates schema, dispatch, and handler signature; thread through to compile_and_collect, which now takes `project : string = ""` and uses make_file_access(project) instead of the previous hardcoded "" — matching the convention used by compile_check / lint / find_symbol. * Deterministic compile order (#7): both the MCP tool and CLI main.das build a sorted array<string> from `keys(against_files)` and iterate that, instead of the unspecified-order table-key iteration. Makes per-candidate report ordering and --check exit behavior reproducible across runs. Drive-by: PERF006 fix in resolve_against_files (reserve before push loop). All test suites still green: 6987 in tests/, 54 find_dupes, 181 MCP (includes 5 updated find_duplicates tests for new signature). MCP end-to-end smoke confirms newline-delimited paths and project parameter both reach the handler. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.