Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Oct 2, 2025

Fix: Put correct cost label for credit payment method.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Changes

Changed cost label to Credits: if the payment method is

How to test

Execute the command aleph instance list with credit instances and check that payment pricing appears with Credits: instead %ALEPH:

@nesitor nesitor requested a review from 1yam October 2, 2025 11:52
@nesitor nesitor self-assigned this Oct 2, 2025
@nesitor nesitor marked this pull request as ready for review October 2, 2025 11:53
Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.23%. Comparing base (c84ea65) to head (93089b8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   61.21%   61.23%   +0.02%     
==========================================
  Files          20       20              
  Lines        3700     3702       +2     
  Branches      528      528              
==========================================
+ Hits         2265     2267       +2     
  Misses       1162     1162              
  Partials      273      273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleph-im aleph-im deleted a comment from github-actions bot Oct 2, 2025
@nesitor nesitor merged commit ba223fd into master Oct 2, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants