[Messages] Check the presence of all fields #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Superseded by #272, but we can imagine a situation where this could be merged and released earlier. |
hoh
previously approved these changes
May 24, 2022
hoh
requested changes
May 24, 2022
hoh
approved these changes
May 24, 2022
odesenfans
force-pushed
the
od-check-presence-of-all-fields-in-messages
branch
from
c303675 to
8d23037
Compare
Broadened the check of fields in new messages. We now check for the presence of all the authorized fields, as parts of the code expect them later anyway. This fixes an issue detected on Sentry where the missing "time" field on some messages triggered an exception.
odesenfans
force-pushed
the
od-check-presence-of-all-fields-in-messages
branch
from
8d23037 to
9fedf24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broadened the check of fields in new messages. We now check for
the presence of all the authorized fields, as parts of the code
expect them later anyway.
This fixes an issue detected on Sentry where the missing "time"
field on some messages triggered an exception.