[Chains] Use pending message model in signature verification #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Depends on #272. |
odesenfans
changed the title
odesenfans
force-pushed
the
od-use-raw-message-in-chain-code
branch
from
3d57ff3 to
cf29ad1
Compare
hoh
approved these changes
May 24, 2022
Member
hoh
left a comment
hoh
left a comment
There was a problem hiding this comment.
Looks good to me, except the JSON in one very long line.
It was there already and is not a regression, so I still approve the PR.
| from aleph.chains.substrate import verify_signature | ||
| from aleph.schemas.pending_messages import parse_message | ||
|
|
||
| TEST_MESSAGE = '{"chain": "DOT", "channel": "TEST", "sender": "5CGNMKCscqN2QNcT7Jtuz23ab7JUxh8wTEtXhECZLJn5vCGX", "type": "AGGREGATE", "item_type": "inline", "time": 1601913525.231501, "item_content": "{\\"key\\":\\"test\\",\\"address\\":\\"5CGNMKCscqN2QNcT7Jtuz23ab7JUxh8wTEtXhECZLJn5vCGX\\",\\"content\\":{\\"a\\":1},\\"time\\":1601913525.231498}", "item_hash": "bfbc94fae6336d52ab65a4d907d399a0c16222bd944b3815faa08ad0e039ca1d", "signature": "{\\"curve\\": \\"sr25519\\", \\"data\\": \\"0x1ccefb257e89b4e3ecb7d71c8dc1d6e286290b9e32d2a11bf3f9d425c5790f4bff0b324dc774d20a13e38a340d1a48fada71fb0c68690c3adb8f0cc695b0eb83\\"}", "content": {"key": "test", "address": "5CGNMKCscqN2QNcT7Jtuz23ab7JUxh8wTEtXhECZLJn5vCGX", "content": {"a": 1}, "time": 1601913525.231498}}' |
Member
There was a problem hiding this comment.
Does this have to be on a single line or could it be indented with triple quotes ?
We now use the `BasePendingMessage` class in the signature verifiers for all supported chains. Modified some tests since we can now make some hypotheses about fields being present (and valid) in the message object.
odesenfans
force-pushed
the
od-use-raw-message-in-chain-code
branch
from
cf29ad1 to
75db19b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use the
BasePendingMessageclass in the signature verifiersfor all supported chains.
Modified some tests since we can now make some hypotheses about
fields being present (and valid) in the message object.