Fix: delete RabbitMQ queues for unused websockets #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is not enough yet, the timeout does work but |
Problem: RabbitMQ queues can stay open indefinitely if the websocket filters only match few or no message. This can lead to increased resource consumption. Solution: add a large timeout (5 minutes) and check periodically if the websocket connection is still open. If the user is still listening, keep the queue open. Otherwise, delete the queue and terminate the request.
odesenfans
force-pushed
the
od-terminate-message-ws-on-connection-closed
branch
from
215a906 to
c064b1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: RabbitMQ queues can stay open indefinitely if the websocket filters only match few or no message. This can lead to increased resource consumption.
Solution: add a large timeout (5 minutes) and check periodically if the websocket connection is still open. If the user is still listening, keep the queue open. Otherwise, delete the queue and terminate the request.