migrate aleph notification to k8s with kuvert #3956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stchris
approved these changes
Nov 4, 2024
Contributor
stchris
left a comment
stchris
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @martyna-autumn ! We're aiming to have this in 4.2. We're right now in a feature freeze for 4.1.
Contributor
Author
|
Thanks! Ill keep my ticket in Jira in blocked state until this is merged |
Contributor
Author
|
@stchris do you know when this change would go live? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mounts new secret for Aleph with environmental variable. It contains a password for a new notification system (kuvert).