Respect the timeout and retry settings for converting documents #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix #573
tillprochaska
approved these changes
Jan 24, 2024
Contributor
tillprochaska
left a comment
tillprochaska
left a comment
There was a problem hiding this comment.
Added two comments that are not directly related to this PR, but this looks good to me in general.
The custom logic for retrying document conversions is no longer necessary. We should be able to rely just on worker retries.
catileptic
approved these changes
Jan 31, 2024
Contributor
catileptic
left a comment
catileptic
left a comment
There was a problem hiding this comment.
Looks reasonable to me, too. I gotta say I appreciate seeing the code base become more tidy and reasonable. Nice work, @stchris !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix alephdata/aleph#3898
These settings were always there, but when we integrated
convert-documentintoingest-filewe didn't hook them up.I've also reduced the defaults to something more sensible ™️