Update CmakeLists.txt for building on windows and add some informatio… #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @alesbe
I think we both had some trouble building on windows before. Took me a bit of time over the past few days but eventually got it to work with the latest version of visual studio. I'm opening this pull request as I made some small changes to CMakeLists.txt which helped me get things working on Windows.
List of changes:
cmake -G 'Visual Studio 17 2022'generates four kinds of releases by default ("Debug", "Release", "MinSizeRel", "RelWithDebInfo") so I added some code to account for this.find_packagetoCONFIGmode. This will search for SFMLConfig.cmake in the SFML_DIR.I haven't yet tested on linux, was hoping you might be able to if you have some spare time.
Let me know of any issues, comments, suggestions and I can fix them up! :)