Update to latest SMAPI & refactor#5
Merged
alexb5dh merged 11 commits intoalexb5dh:masterfrom Feb 21, 2017
Pathoschild:feature/update-to-latest-SMAPI
Merged
Update to latest SMAPI & refactor#5alexb5dh merged 11 commits intoalexb5dh:masterfrom Pathoschild:feature/update-to-latest-SMAPI
alexb5dh merged 11 commits intoalexb5dh:masterfrom
Pathoschild:feature/update-to-latest-SMAPI
Conversation
SMAPI 1.9+ serialises Buttons and Keys enums as strings automatically, and null value handling is generally unnecessary.
…sed NuGet package
Owner
|
Big thanks for refactoring and documentation. |
Owner
|
Looks like Json.NET reference removal was too early since Keys serialization as string will only be added in 1.9. |
Contributor
Author
|
The previous version works fine with SMAPI 1.8; how about releasing this as the SMAPI 1.9 / Stardew Valley 1.2 version? |
Owner
|
I'm all for it. Are there any estimation dates for 1.2? |
Contributor
Author
|
Not that I know of, but development and feedback is slowing down so I'd guess within the next week or two. |
Owner
|
Ok, I'll keep track of the news then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request...