Skip to content

Update to latest SMAPI & refactor#5

Merged
alexb5dh merged 11 commits intoalexb5dh:masterfrom
Pathoschild:feature/update-to-latest-SMAPI
Feb 21, 2017
Merged

Update to latest SMAPI & refactor#5
alexb5dh merged 11 commits intoalexb5dh:masterfrom
Pathoschild:feature/update-to-latest-SMAPI

Conversation

@Pathoschild
Copy link
Copy Markdown
Contributor

This pull request...

  • migrates to the latest SMAPI APIs (which lets us simplify the config and logging code quite a bit);
  • marks all internal classes internal;
  • copyedits & adds missing code documentation;
  • applies .NET best practices (e.g. one class per file);
  • applies SMAPI best practices (e.g. avoid lambdas as event handlers);
  • removes now-unused dependencies on Json.NET and the MSBuild extensions pack.

@alexb5dh
Copy link
Copy Markdown
Owner

Big thanks for refactoring and documentation.
Will check this in game and publish a new release in a few days.

@alexb5dh alexb5dh merged commit 3cd15b0 into alexb5dh:master Feb 21, 2017
@alexb5dh
Copy link
Copy Markdown
Owner

Looks like Json.NET reference removal was too early since Keys serialization as string will only be added in 1.9.

@Pathoschild Pathoschild deleted the feature/update-to-latest-SMAPI branch February 21, 2017 01:18
@Pathoschild
Copy link
Copy Markdown
Contributor Author

The previous version works fine with SMAPI 1.8; how about releasing this as the SMAPI 1.9 / Stardew Valley 1.2 version?

@alexb5dh
Copy link
Copy Markdown
Owner

I'm all for it. Are there any estimation dates for 1.2?

@Pathoschild
Copy link
Copy Markdown
Contributor Author

Not that I know of, but development and feedback is slowing down so I'd guess within the next week or two.

@alexb5dh
Copy link
Copy Markdown
Owner

Ok, I'll keep track of the news then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants