Skip to content

Fix Resolver#create_tsig_options visibility.#67

Closed
keithrbennett wants to merge 2 commits into
alexdalitz:masterfrom
keithrbennett:fix-create-tsig-options
Closed

Fix Resolver#create_tsig_options visibility.#67
keithrbennett wants to merge 2 commits into
alexdalitz:masterfrom
keithrbennett:fix-create-tsig-options

Conversation

@keithrbennett
Copy link
Copy Markdown
Contributor

  • Make Resolver#create_tsig_options public instead of private to fix error.
  • Add require to tc_dnsruby.rb so it will pass when called individually.

@keithrbennett
Copy link
Copy Markdown
Contributor Author

Also, I removed the comments from Resolver#tsig= that referred to passing multiple arguments.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 75.75% when pulling 4ab7f4a on keithrbennett:fix-create-tsig-options into 741b3d9 on alexdalitz:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 75.75% when pulling 4ab7f4a on keithrbennett:fix-create-tsig-options into 741b3d9 on alexdalitz:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.18%) to 75.56% when pulling 4ab7f4a on keithrbennett:fix-create-tsig-options into 741b3d9 on alexdalitz:master.

@keithrbennett
Copy link
Copy Markdown
Contributor Author

Removed "=> _e" from rescue since there was an end immediately following it.

@alexdalitz
Copy link
Copy Markdown
Owner

Hi -

Thanks for this!

I've used the tc_dnsruby fix separately. The TSIG and AXFR stuff is also addresses separately, so I'm going to close this pull request.

Thanks!

Alex.

@alexdalitz alexdalitz closed this Feb 14, 2015
@keithrbennett keithrbennett deleted the fix-create-tsig-options branch March 25, 2015 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants