Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features to the reporting and user profile functionality, focusing on volunteer hours reporting, user email handling, and UI enhancements. The main changes include more accurate and user-friendly formatting of volunteer hours, improved filtering and capping logic for hours calculations, enhanced user privacy and email handling, and the addition of a sorting feature for reports.
Volunteer Hours Calculation and Formatting
formatHoursfor consistent and user-friendly formatting of hours, trimming unnecessary trailing zeros and handling edge cases. [1] [2] [3]_capVolunteerHourshelper to ensure hours are clamped between 0 and 8 per event, and exposedvolunteerHoursForUserEventfor consistent usage across the codebase. [1] [2] [3]userEventsInRangeto use UTC times and correct filter logic, ensuring only relevant events are included in reports.User Profile and Email Handling
UserModelwith logic to detect placeholder emails, determine if a user can receive email, and expose a safeemailForMailingproperty, improving privacy and data quality for exports and communication. [1] [2]Reporting UI and Usability
AnyStepBadgemore flexible by allowing custom padding and border radius.Snackbar Usability
Other Improvements
These changes collectively improve the accuracy, usability, and maintainability of the reporting and user profile features.