feat: add idempotency middleware and extract reusable ResponseBuffer#91
Merged
feat: add idempotency middleware and extract reusable ResponseBuffer#91
Conversation
Owner
alexferl
commented
Mar 13, 2026
alexferl
commented
- Add idempotency middleware with configurable IdempotencyStore interface
- Extract ResponseBuffer to internal/rwutil for shared use by cache/etag/idempotency
- Optimize cache key generation: SHA-256 → strings.Builder with Grow (78% faster)
- Update JWT TokenStore interface for consistency
- Add idempotency middleware with configurable IdempotencyStore interface - Extract ResponseBuffer to internal/rwutil for shared use by cache/etag/idempotency - Optimize cache key generation: SHA-256 → strings.Builder with Grow (78% faster) - Update JWT TokenStore interface for consistency Signed-off-by: alexferl <me@alexferl.com>
Pull Request Test Coverage Report for Build 23037474765Details
💛 - Coveralls |
Add b.Grow() calls to buildCanonicalRequest functions in hmac_signer.go and hmac_auth.go to reduce allocations. Improves HMAC auth by up to 24% with 23-30% fewer allocations. Signed-off-by: alexferl <me@alexferl.com>
Both middleware were replaying cached headers on top of headers already set by other middleware (security headers, request IDs). Now they skip replaying any header key that's already present in the response. Signed-off-by: alexferl <me@alexferl.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.