fix(release): decouple shared api version from plugin releases#5
Merged
fix(release): decouple shared api version from plugin releases#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extension-apiandruntime-apidependency management from per-plugin${project.version}bumpsplugin.api.versionrepository property and validate it inscripts/plugins_repo.pyRoot cause
release_mainbumps an individual plugin version before building it. The parentpom.xmlstill managedgolemcore-plugin-extension-apiandgolemcore-plugin-runtime-apiwith${project.version}. After a plugin bump, Maven tried to resolve non-existent API artifacts likegolemcore-plugin-extension-api:1.0.1, so the release build failed before publishing packages.What changed
dependencyManagementnow pins shared API dependencies viaplugin.api.versioninstead of${project.version}plugin.api.versionCONTRIBUTING.mdnow documents the independent shared API versioning ruleVerification
python3 scripts/plugins_repo.py validatemvn -B -ntp -P strict verifymvn -B -ntp -P strict verify -pl extension-api,runtime-api,golemcore/telegram -ampython3 scripts/plugins_repo.py release --plugin golemcore/telegram --bump patchgolemcore/telegram 1.0.1successfully withextension-apiandruntime-apiincluded in the reactor