feat: add integration testing suite for OpenAI endpoints#50
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive integration test suite for the modelship service, covering chat completions, streaming, tool calling, embeddings, and audio processing. It also adds a tool_call_parser field to the TransformersConfig and registers an integration marker in pyproject.toml. Key feedback includes fixing a bug where signal constants were incorrectly accessed via the subprocess module, replacing the deprecated preexec_fn with start_new_session, and improving test robustness by using the tmp_path fixture and relative pathing for configuration files.
06b1752 to
1a5c638
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.