Skip to content

Added NativeExpression and PortableSqlExpression#366

Merged
gilleain merged 5 commits intomainfrom
feature/portable_sql_expression
Feb 4, 2026
Merged

Added NativeExpression and PortableSqlExpression#366
gilleain merged 5 commits intomainfrom
feature/portable_sql_expression

Conversation

@JamesEvennettGH
Copy link
Copy Markdown

Add new element NativeExpression to facilitate inputting native SQL code for a given database type. Added PortableSqlExpression to encapsulate such expressions.

Prototype of changes.

Copy link
Copy Markdown
Contributor

@jsimlo jsimlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great prototype! 👍

Comment thread morf-core/src/main/java/org/alfasoftware/morf/jdbc/SqlDialect.java Outdated
Comment thread morf-mysql/src/main/java/org/alfasoftware/morf/jdbc/mysql/MySqlDialect.java Outdated
@JamesEvennettGH JamesEvennettGH marked this pull request as ready for review January 28, 2026 13:15
Comment thread morf-core/src/main/java/org/alfasoftware/morf/sql/element/NativeExpression.java Outdated
Comment thread morf-core/src/main/java/org/alfasoftware/morf/jdbc/SqlDialect.java
Comment thread morf-core/src/main/java/org/alfasoftware/morf/jdbc/SqlDialect.java Outdated
Comment thread morf-core/src/main/java/org/alfasoftware/morf/jdbc/SqlDialect.java
@sonarqubecloud
Copy link
Copy Markdown

@jsimlo
Copy link
Copy Markdown
Contributor

jsimlo commented Jan 29, 2026

I am happy with the review.
Would be good if we got one Morf maintainer to review, just in case :)
cc @jonknight73 @capgen628 @gilleain for the usuals :)

@gilleain gilleain self-assigned this Feb 4, 2026
@gilleain gilleain merged commit a830100 into main Feb 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants