Merged
Conversation
jeeeesper
force-pushed
the
aligner-api
branch
2 times, most recently
from
0e124fc to
03b9fef
Compare
This moves ranges and memory limits to align(...) call, but allows to configure and parse costs upfront.
jeeeesper
force-pushed
the
aligner-api
branch
from
03b9fef to
01a2428
Compare
sebschmi
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves ranges and memory limits to the individual align(...) call. That allows to reuse an
Aligner, which in turn means that costs and other alignment strategy can be parsed / configured only once upfront.This branch is rebased ondont-panic-on-extend, at least to avoid a clippy lint that would make the pipeline fail. So perhaps #90 should be merged first.