Simplify logic and avoid overflow in msolve.c#281
Merged
mohabsafey merged 3 commits intoalgebraic-solving:masterfrom Mar 12, 2026
Merged
Simplify logic and avoid overflow in msolve.c#281mohabsafey merged 3 commits intoalgebraic-solving:masterfrom
msolve.c#281mohabsafey merged 3 commits intoalgebraic-solving:masterfrom
Conversation
Contributor
|
Thanks. This looks very much ok for being merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #277 .
This simpler code should do the same thing as the one that was present. However I'm not sure that the one that was present had the intended behaviour, since some
sumvalue was computed and never used (see #277 ).